Bug 125899

Summary: [MSE] Add per-track signalling between SourceBuffer and SourceBufferPrivate.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, glenn
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 125905    
Attachments:
Description Flags
Patch none

Jer Noble
Reported 2013-12-17 18:22:23 PST
[MSE] Add per-track signalling between SourceBuffer and SourceBufferPrivate.
Attachments
Patch (12.62 KB, patch)
2013-12-17 18:31 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2013-12-17 18:31:04 PST
Created attachment 219485 [details] Patch
Eric Carlson
Comment 2 2013-12-17 18:56:01 PST
Comment on attachment 219485 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=219485&action=review > Source/WebCore/Modules/mediasource/SourceBuffer.h:143 > + struct TrackBuffer; Don't we usually forward declare structs and classes above the class?
Jer Noble
Comment 3 2013-12-17 22:01:38 PST
(In reply to comment #2) > (From update of attachment 219485 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=219485&action=review > > > Source/WebCore/Modules/mediasource/SourceBuffer.h:143 > > + struct TrackBuffer; > > Don't we usually forward declare structs and classes above the class? Usually, yes, but this is a nested struct. It has to be declared within the declaration of SourceBuffer.
WebKit Commit Bot
Comment 4 2013-12-17 22:46:34 PST
Comment on attachment 219485 [details] Patch Clearing flags on attachment: 219485 Committed r160754: <http://trac.webkit.org/changeset/160754>
WebKit Commit Bot
Comment 5 2013-12-17 22:46:36 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.