Bug 138985

Summary: RenderElement::removeChild() doesn't need a return value.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: kling, koivisto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch koivisto: review+

Andreas Kling
Reported 2014-11-21 15:14:00 PST
It looks like nobody uses the return value from RenderElement::removeChild(). Instead of plumbing it through everywhere, we should just remove it. ((Maybe someday, removeChild() could return a smart pointer that owns the renderer that got removed.))
Attachments
Patch (34.72 KB, patch)
2014-11-21 15:14 PST, Andreas Kling 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-11-21 15:14:30 PST
Created attachment 242076 [details] Patch
Andreas Kling
Comment 2 2014-11-21 15:40:29 PST
http://trac.webkit.org/changeset/176478
Note You need to log in before you can comment on or make changes to this bug.