Bug 141226

Summary: Don’t use repository names as id’s.
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: WebKit WebsiteAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 141220    
Bug Blocks: 138516    
Attachments:
Description Flags
Refactoring
none
Fixed the patch cdumez: review+

Ryosuke Niwa
Reported 2015-02-03 17:46:58 PST
Right now, the perf dashboard uses the repository names as repository id’s. This forces runs.php to run an unnecessary SQL query on every request. Don’t do that.
Attachments
Refactoring (14.64 KB, patch)
2015-02-03 17:58 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixed the patch (15.91 KB, patch)
2015-02-03 18:06 PST, Ryosuke Niwa 		cdumez: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2015-02-03 17:58:11 PST
Created attachment 245999 [details] Refactoring
Ryosuke Niwa
Comment 2 2015-02-03 18:06:05 PST
Created attachment 246004 [details] Fixed the patch
Chris Dumez
Comment 3 2015-02-03 19:10:03 PST
Comment on attachment 246004 [details] Fixed the patch View in context: https://bugs.webkit.org/attachment.cgi?id=246004&action=review rs=me > Websites/perf.webkit.org/ChangeLog:9 > + Since names of repositories are available in manifest.json, we can resole their names in the front end. "resolve"
Ryosuke Niwa
Comment 4 2015-02-03 21:40:09 PST
Thanks for the review!
Ryosuke Niwa
Comment 5 2015-02-03 21:40:36 PST
Committed r179591: <http://trac.webkit.org/changeset/179591>
Note You need to log in before you can comment on or make changes to this bug.