Bug 150417

Summary: Get rid of useBinaryEncoding from WKPageGetContentsAsMHTMLData
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch thorton: review+

Anders Carlsson
Reported 2015-10-21 14:33:51 PDT
Get rid of useBinaryEncoding from WKPageGetContentsAsMHTMLData
Attachments
Patch (9.61 KB, patch)
2015-10-21 14:44 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (9.67 KB, patch)
2015-10-21 14:54 PDT, Anders Carlsson 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2015-10-21 14:44:57 PDT
Created attachment 263742 [details] Patch
WebKit Commit Bot
Comment 2 2015-10-21 14:47:03 PDT
Attachment 263742 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2642: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:755: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2015-10-21 14:54:45 PDT
Created attachment 263743 [details] Patch
WebKit Commit Bot
Comment 4 2015-10-21 14:56:28 PDT
Attachment 263743 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2642: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:755: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 5 2015-10-21 15:09:40 PDT
Comment on attachment 263743 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263743&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:-2530 > - ? MHTMLArchive::generateMHTMLDataUsingBinaryEncoding(m_page.get()) If you're doing this, why not go further and remove generateMHTMLDataUsingBinaryEncoding from MHTMLArchive.h and cpp?
Tim Horton
Comment 6 2015-10-21 15:13:44 PDT
Comment on attachment 263743 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263743&action=review >> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:-2530 >> - ? MHTMLArchive::generateMHTMLDataUsingBinaryEncoding(m_page.get()) > > If you're doing this, why not go further and remove generateMHTMLDataUsingBinaryEncoding from MHTMLArchive.h and cpp? Yeah, it doesn't look like there are other callers.
Anders Carlsson
Comment 7 2015-10-21 15:15:31 PDT
(In reply to comment #6) > Comment on attachment 263743 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=263743&action=review > > >> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:-2530 > >> - ? MHTMLArchive::generateMHTMLDataUsingBinaryEncoding(m_page.get()) > > > > If you're doing this, why not go further and remove generateMHTMLDataUsingBinaryEncoding from MHTMLArchive.h and cpp? > > Yeah, it doesn't look like there are other callers. Going to do that in a follow-up patch!
Anders Carlsson
Comment 8 2015-10-21 15:30:40 PDT
Committed r191408: <http://trac.webkit.org/changeset/191408>
Note You need to log in before you can comment on or make changes to this bug.