Bug 164686

Summary: Use #pragma once in WebCore
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebCore Misc.Assignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, joepeck
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2016-11-12 12:36:55 PST
This gets use everything except ForwardingHeaders, WebCore/platform, and a few weird files that I don't know what to do with.
Attachments
[PATCH] Proposed Fix (300.55 KB, patch)
2016-11-12 12:43 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (300.58 KB, patch)
2016-11-12 15:23 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2016-11-12 12:43:23 PST
Created attachment 294627 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 2 2016-11-12 12:45:07 PST
Comment on attachment 294627 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=294627&action=review > Source/WebCore/rendering/style/TextSizeAdjustment.h:25 > +// FIXME: Namespace WebCore? I'll look into this now. It seems weird that there was no namespace here.
WebKit Commit Bot
Comment 3 2016-11-12 12:46:56 PST
Attachment 294627 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RegionOversetState.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 1 in 545 files If any of these errors are false positives, please file a bug against check-webkit-style.
Joseph Pecoraro
Comment 4 2016-11-12 15:23:56 PST
Created attachment 294637 [details] [PATCH] Proposed Fix Added the missing namespace.
WebKit Commit Bot
Comment 5 2016-11-12 15:25:55 PST
Attachment 294637 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RegionOversetState.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 1 in 545 files If any of these errors are false positives, please file a bug against check-webkit-style.
Michael Catanzaro
Comment 6 2016-11-12 18:25:10 PST
(In reply to comment #5) > Attachment 294637 [details] did not pass style-queue: > > > ERROR: Source/WebCore/rendering/RegionOversetState.h:0: No copyright > message found. You should have a line: "Copyright [year] <Copyright Owner>" > [legal/copyright] [5] > Total errors found: 1 in 545 files Seems like as good a time as any to fix this.
Joseph Pecoraro
Comment 7 2016-11-13 01:42:50 PST
> > ERROR: Source/WebCore/rendering/RegionOversetState.h:0: No copyright > > message found. You should have a line: "Copyright [year] <Copyright Owner>" > > [legal/copyright] [5] > > Total errors found: 1 in 545 files > > Seems like as good a time as any to fix this. This file actually has a really old copyright so I left it as is.
WebKit Commit Bot
Comment 8 2016-11-13 02:08:57 PST
Comment on attachment 294637 [details] [PATCH] Proposed Fix Clearing flags on attachment: 294637 Committed r208668: <http://trac.webkit.org/changeset/208668>
WebKit Commit Bot
Comment 9 2016-11-13 02:09:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.