Bug 167870

Summary: [EME] Implement MediaKeySession::remove()
Product: WebKit Reporter: Zan Dobersek <zan>
Component: WebCore Misc.Assignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, jer.noble
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 158841    
Attachments:
Description Flags
Patch
none
Patch for landing none

Zan Dobersek
Reported 2017-02-05 23:36:30 PST
SSIA.
Attachments
Patch (21.20 KB, patch)
2017-02-06 01:19 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (20.22 KB, patch)
2017-02-08 02:39 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2017-02-06 01:19:55 PST
Created attachment 300698 [details] Patch
Xabier Rodríguez Calvar
Comment 2 2017-02-06 02:18:02 PST
Comment on attachment 300698 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300698&action=review > Source/WebCore/testing/MockCDMFactory.h:75 > + Vector<Ref<SharedBuffer>> removeKeysFromSessionWithID(const String& id); You don't need the parameter name here.
Jer Noble
Comment 3 2017-02-06 08:47:52 PST
Comment on attachment 300698 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300698&action=review > Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp:422 > + CDMInstance::LicenseType sessionType; > + switch (m_sessionType) { > + case MediaKeySessionType::Temporary: > + sessionType = CDMInstance::LicenseType::Temporary; > + break; > + case MediaKeySessionType::PersistentLicense: > + sessionType = CDMInstance::LicenseType::Persistable; > + break; > + case MediaKeySessionType::PersistentUsageRecord: > + sessionType = CDMInstance::LicenseType::UsageRecord; > + break; > + }; This pattern happens enough in the new MSE code that we should have a conversion routine to cast between MediaKeySessionType <-> LicenseType.
Zan Dobersek
Comment 4 2017-02-06 11:45:33 PST
(In reply to comment #3) > This pattern happens enough in the new MSE code that we should have a > conversion routine to cast between MediaKeySessionType <-> LicenseType. Posted a patch in bug #167896.
Xabier Rodríguez Calvar
Comment 5 2017-02-07 01:11:49 PST
(In reply to comment #3) > > Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp:422 > > + CDMInstance::LicenseType sessionType; > > + switch (m_sessionType) { > > + case MediaKeySessionType::Temporary: > > + sessionType = CDMInstance::LicenseType::Temporary; > > + break; > > + case MediaKeySessionType::PersistentLicense: > > + sessionType = CDMInstance::LicenseType::Persistable; > > + break; > > + case MediaKeySessionType::PersistentUsageRecord: > > + sessionType = CDMInstance::LicenseType::UsageRecord; > > + break; > > + }; > > This pattern happens enough in the new MSE code that we should have a > conversion routine to cast between MediaKeySessionType <-> LicenseType. I thought of that too but I thought it might be left for a rework later. Same goes for several functions that we have on the tests and I am seeing repeated during the latest patches review processes.
Zan Dobersek
Comment 6 2017-02-08 02:39:19 PST
Created attachment 300886 [details] Patch for landing
Zan Dobersek
Comment 7 2017-02-08 02:41:22 PST
Comment on attachment 300886 [details] Patch for landing Clearing flags on attachment: 300886 Committed r211857: <http://trac.webkit.org/changeset/211857>
Zan Dobersek
Comment 8 2017-02-08 02:41:30 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.