Bug 170556

Summary: REGRESSION (r209882): Web Inspector: Console's filter bar has text search field, but the next/previous buttons don't do anything
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, mattbaker, nvasilyev, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=164847
https://bugs.webkit.org/show_bug.cgi?id=170555
Attachments:
Description Flags
Patch none

Blaze Burg
Reported 2017-04-06 11:04:59 PDT
We should remove these until we plan to actually make this a find bar instead of a filter bar (e.g., https://bugs.webkit.org/show_bug.cgi?id=164847).
Attachments
Patch (2.46 KB, patch)
2017-04-19 13:24 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-04-06 11:05:35 PDT
<rdar://problem/31481755>
Nikita Vasilyev
Comment 2 2017-04-18 16:48:18 PDT
This broke in https://trac.webkit.org/changeset/209882/webkit.
Nikita Vasilyev
Comment 3 2017-04-18 17:11:32 PDT
From UserInterface/Views/FindBanner.js: set numberOfResults(numberOfResults) { if (numberOfResults === undefined || isNaN(numberOfResults)) numberOfResults = null; this._numberOfResults = numberOfResults; this._previousResultButton.disabled = this._nextResultButton.disabled = (numberOfResults <= 0); It appears that when searching in Console tab, next/previous buttons of an instance of WebInspector.FindBanner gets disabled as expected. That problem is that it's a wrong instance of WebInspector.FindBanner, one that isn't even attached to the DOM. this._previousResultButton.parentNode // null
Nikita Vasilyev
Comment 4 2017-04-18 18:38:33 PDT
My comment above might be unrelated to this bug. See https://bugs.webkit.org/show_bug.cgi?id=164047#c10 for the cause of this regression.
Nikita Vasilyev
Comment 5 2017-04-19 13:24:33 PDT
Created attachment 307503 [details] Patch
Matt Baker
Comment 6 2017-04-19 16:16:56 PDT
Comment on attachment 307503 [details] Patch r=me
WebKit Commit Bot
Comment 7 2017-04-19 16:41:22 PDT
Comment on attachment 307503 [details] Patch Clearing flags on attachment: 307503 Committed r215543: <http://trac.webkit.org/changeset/215543>
WebKit Commit Bot
Comment 8 2017-04-19 16:41:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.