Bug 174591

Summary: Layout Test media/video-add-autoplay-user-gesture.html is flaky.
Product: WebKit Reporter: Matt Lewis <jlewis3>
Component: New BugsAssignee: Ryan Haddad <ryanhaddad>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, eric.carlson, jer.noble, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=174373
Attachments:
Description Flags
Patch none

Matt Lewis
Reported 2017-07-17 11:28:37 PDT
media/video-add-autoplay-user-gesture.html is a flaky failure on macOS Sierra Release WK2. It looks to have been flaky since being added. https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fvideo-add-autoplay-user-gesture.html https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r219562%20(2990)/results.html Diff: --- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/media/video-add-autoplay-user-gesture-expected.txt +++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/media/video-add-autoplay-user-gesture-actual.txt @@ -3,6 +3,6 @@ RUN(video.src = findMediaFile("video", "content/test")) RUN(video.setAttribute("autoplay", "")) RUN(document.body.appendChild(video)) -EVENT(playing) +FAIL: did not end fast enough END OF TEST
Attachments
Patch (1.30 KB, patch)
2018-07-31 09:05 PDT, Ryan Haddad 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2017-07-24 09:17:22 PDT
Looks like we should just remove the "failTestIn(1000)" call and allow the test to take the full timeout value (20s) before failing.
Ryan Haddad
Comment 2 2018-07-31 08:59:54 PDT
I can easily reproduce this failure on Mojave with: run-webkit-tests media/video-add-autoplay-user-gesture.html -fg --iter 25
Ryan Haddad
Comment 3 2018-07-31 09:05:26 PDT
Created attachment 346170 [details] Patch
Ryan Haddad
Comment 4 2018-07-31 09:06:16 PDT
With the attached patch, the test passes 100/100 times.
WebKit Commit Bot
Comment 5 2018-07-31 09:52:48 PDT
Comment on attachment 346170 [details] Patch Clearing flags on attachment: 346170 Committed r234428: <https://trac.webkit.org/changeset/234428>
WebKit Commit Bot
Comment 6 2018-07-31 09:52:50 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-07-31 09:57:47 PDT
<rdar://problem/42775727>
Note You need to log in before you can comment on or make changes to this bug.