Bug 187738

Summary: [WHLSL] Test suite for Metal code generation
Product: WebKit Reporter: Thomas Denney <tdenney>
Component: New BugsAssignee: Thomas Denney <tdenney>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, ews-watchlist, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 187735    
Bug Blocks: 176199    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews206 for win-future
none
WIP
none
WIP
none
Archive of layout-test-results from ews125 for ios-simulator-wk2
none
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
WIP
none
Patch
mmaxfield: review+, commit-queue: commit-queue-
Patch none

Thomas Denney
Reported 2018-07-17 14:24:03 PDT
Adding WHLSL Compiler Tests
Attachments
Patch (234.92 KB, patch)
2018-07-17 14:25 PDT, Thomas Denney 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews206 for win-future (13.09 MB, application/zip)
2018-07-18 12:03 PDT, EWS Watchlist 		no flags
Details
WIP (428.92 KB, patch)
2018-08-10 19:45 PDT, Thomas Denney 		no flags
DetailsFormatted DiffDiff
WIP (427.64 KB, patch)
2018-08-14 11:01 PDT, Thomas Denney 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.47 MB, application/zip)
2018-08-14 12:54 PDT, EWS Watchlist 		no flags
Details
WIP (427.98 KB, patch)
2018-08-14 18:54 PDT, Thomas Denney 		no flags
DetailsFormatted DiffDiff
WIP (440.03 KB, patch)
2018-08-27 20:08 PDT, Thomas Denney 		no flags
DetailsFormatted DiffDiff
WIP (448.54 KB, patch)
2018-08-29 10:13 PDT, Thomas Denney 		no flags
DetailsFormatted DiffDiff
WIP (426.37 KB, patch)
2018-08-31 20:13 PDT, Thomas Denney 		no flags
DetailsFormatted DiffDiff
WIP (429.35 KB, patch)
2018-09-14 00:52 PDT, Thomas Denney 		no flags
DetailsFormatted DiffDiff
WIP (430.51 KB, patch)
2018-09-14 15:26 PDT, Thomas Denney 		no flags
DetailsFormatted DiffDiff
Patch (292.77 KB, patch)
2018-09-21 16:32 PDT, Thomas Denney 		mmaxfield: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Patch (292.42 KB, patch)
2018-09-25 13:07 PDT, Thomas Denney 		no flags
DetailsFormatted DiffDiff
Show Obsolete (11) View All Add attachment proposed patch, testcase, etc.
Thomas Denney
Comment 1 2018-07-17 14:25:41 PDT
Created attachment 345192 [details] Patch
EWS Watchlist
Comment 2 2018-07-18 12:03:29 PDT
Comment on attachment 345192 [details] Patch Attachment 345192 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8576595 New failing tests: http/tests/security/local-video-source-from-remote.html
EWS Watchlist
Comment 3 2018-07-18 12:03:41 PDT
Created attachment 345267 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Thomas Denney
Comment 4 2018-08-10 19:45:56 PDT
Created attachment 346955 [details] WIP
EWS Watchlist
Comment 5 2018-08-10 19:49:58 PDT
Attachment 346955 [details] did not pass style-queue: ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:81: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:105: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:70: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:76: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m:61: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m:77: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.h:21: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:80: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:178: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:179: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:181: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:184: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:185: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:201: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:202: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:204: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:205: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:207: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:208: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:222: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:223: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h:12: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h:10: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:743: developmentRegion is not English. [xcodeproj/settings] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:28: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:106: Missing space around : in range-based for statement [whitespace/colon] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:121: Missing space around : in range-based for statement [whitespace/colon] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:126: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:135: Missing space around : in range-based for statement [whitespace/colon] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:140: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:150: Missing space around : in range-based for statement [whitespace/colon] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:164: Missing space around : in range-based for statement [whitespace/colon] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.h:15: Missing space after , [whitespace/comma] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h:10: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:63: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:84: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:95: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:99: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:103: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:107: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:111: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:115: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:119: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:119: Missing space after , [whitespace/comma] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:127: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:131: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:135: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:139: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:143: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:148: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:149: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:150: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 67 in 76 files If any of these errors are false positives, please file a bug against check-webkit-style.
Thomas Denney
Comment 6 2018-08-14 11:01:01 PDT
Created attachment 347094 [details] WIP
EWS Watchlist
Comment 7 2018-08-14 11:03:52 PDT
Attachment 347094 [details] did not pass style-queue: ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:36: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:81: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:105: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:70: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:76: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m:61: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m:77: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.h:21: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:80: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:178: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:179: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:181: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:184: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:185: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:201: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:202: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:204: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:205: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:207: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:208: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:222: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:223: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h:12: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h:10: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:744: developmentRegion is not English. [xcodeproj/settings] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:28: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:106: Missing space around : in range-based for statement [whitespace/colon] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:121: Missing space around : in range-based for statement [whitespace/colon] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:126: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:135: Missing space around : in range-based for statement [whitespace/colon] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:140: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:150: Missing space around : in range-based for statement [whitespace/colon] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:164: Missing space around : in range-based for statement [whitespace/colon] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.h:15: Missing space after , [whitespace/comma] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h:10: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:63: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:84: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:95: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:99: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:103: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:107: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:111: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:115: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:119: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:119: Missing space after , [whitespace/comma] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:127: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:131: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:135: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:139: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:143: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:148: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:149: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:150: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 68 in 77 files If any of these errors are false positives, please file a bug against check-webkit-style.
EWS Watchlist
Comment 8 2018-08-14 12:54:37 PDT
Comment on attachment 347094 [details] WIP Attachment 347094 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/8857711 New failing tests: svg/custom/scrolling-embedded-svg-file-image-repaint-problem.html
EWS Watchlist
Comment 9 2018-08-14 12:54:39 PDT
Created attachment 347104 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Thomas Denney
Comment 10 2018-08-14 18:54:12 PDT
Created attachment 347142 [details] WIP
EWS Watchlist
Comment 11 2018-08-14 18:57:31 PDT
Attachment 347142 [details] did not pass style-queue: ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:36: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:81: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:105: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:70: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:76: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m:61: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m:77: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.h:21: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:80: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:178: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:179: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:181: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:184: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:185: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:201: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:202: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:204: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:205: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:207: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:208: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:222: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:223: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h:12: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h:10: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:744: developmentRegion is not English. [xcodeproj/settings] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:28: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:106: Missing space around : in range-based for statement [whitespace/colon] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:121: Missing space around : in range-based for statement [whitespace/colon] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:126: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:135: Missing space around : in range-based for statement [whitespace/colon] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:140: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:150: Missing space around : in range-based for statement [whitespace/colon] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:164: Missing space around : in range-based for statement [whitespace/colon] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.h:15: Missing space after , [whitespace/comma] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h:10: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:63: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:84: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:95: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:99: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:103: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:107: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:111: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:115: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:119: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:119: Missing space after , [whitespace/comma] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:127: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:131: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:135: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:139: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:143: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:148: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:149: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:150: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 68 in 77 files If any of these errors are false positives, please file a bug against check-webkit-style.
Thomas Denney
Comment 12 2018-08-27 20:08:15 PDT
Created attachment 348258 [details] WIP
Thomas Denney
Comment 13 2018-08-29 10:13:21 PDT
Created attachment 348410 [details] WIP
EWS Watchlist
Comment 14 2018-08-29 10:17:42 PDT
Attachment 348410 [details] did not pass style-queue: ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:36: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:81: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:105: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:70: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:76: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m:61: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m:77: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.h:21: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:80: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:178: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:179: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:181: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:184: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:185: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:201: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:202: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:204: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:205: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:207: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:208: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:222: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:223: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h:12: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h:10: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:750: developmentRegion is not English. [xcodeproj/settings] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:28: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:106: Missing space around : in range-based for statement [whitespace/colon] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:121: Missing space around : in range-based for statement [whitespace/colon] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:126: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:135: Missing space around : in range-based for statement [whitespace/colon] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:140: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:150: Missing space around : in range-based for statement [whitespace/colon] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:164: Missing space around : in range-based for statement [whitespace/colon] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.h:15: Missing space after , [whitespace/comma] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h:10: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:63: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:84: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:95: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:99: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:103: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:107: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:111: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:115: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:119: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:119: Missing space after , [whitespace/comma] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:127: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:131: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:135: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:139: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:143: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:148: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:149: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:150: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 68 in 79 files If any of these errors are false positives, please file a bug against check-webkit-style.
Thomas Denney
Comment 15 2018-08-31 20:13:43 PDT
Created attachment 348702 [details] WIP
EWS Watchlist
Comment 16 2018-08-31 20:19:43 PDT
Attachment 348702 [details] did not pass style-queue: ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:36: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:81: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:105: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:65: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:71: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m:77: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m:93: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.h:21: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:80: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:178: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:179: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:181: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:184: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:185: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:201: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:202: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:204: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:205: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:207: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:208: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:222: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:223: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h:12: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h:10: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:738: developmentRegion is not English. [xcodeproj/settings] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.h:19: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m:14: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:28: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:117: Missing space around : in range-based for statement [whitespace/colon] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:132: Missing space around : in range-based for statement [whitespace/colon] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:137: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:146: Missing space around : in range-based for statement [whitespace/colon] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:151: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:161: Missing space around : in range-based for statement [whitespace/colon] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:175: Missing space around : in range-based for statement [whitespace/colon] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.h:15: Missing space after , [whitespace/comma] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h:10: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:63: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:84: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:95: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:99: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:103: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:107: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:111: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:115: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:119: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:119: Missing space after , [whitespace/comma] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:127: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:131: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:135: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:139: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:143: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:148: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:149: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:150: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 70 in 72 files If any of these errors are false positives, please file a bug against check-webkit-style.
Thomas Denney
Comment 17 2018-09-14 00:52:05 PDT
Created attachment 349746 [details] WIP
EWS Watchlist
Comment 18 2018-09-14 00:56:19 PDT
Attachment 349746 [details] did not pass style-queue: ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:36: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:81: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:65: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:71: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m:88: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:72: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:160: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:161: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:163: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:166: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:167: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:183: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:184: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:186: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:187: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:189: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:190: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:204: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:205: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h:12: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h:10: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:804: developmentRegion is not English. [xcodeproj/settings] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.h:21: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.h:15: Missing space after , [whitespace/comma] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:28: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:144: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.h:22: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h:10: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h:26: Missing space after , [whitespace/comma] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:92: Missing space after , [whitespace/comma] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:99: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:120: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:134: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:138: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:142: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:146: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:150: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:155: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:159: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:163: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:167: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:167: Missing space after , [whitespace/comma] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:175: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:179: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:183: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:187: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:191: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:195: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:200: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:201: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:202: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:203: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 67 in 63 files If any of these errors are false positives, please file a bug against check-webkit-style.
Thomas Denney
Comment 19 2018-09-14 15:26:49 PDT
Created attachment 349818 [details] WIP
EWS Watchlist
Comment 20 2018-09-14 15:31:09 PDT
Attachment 349818 [details] did not pass style-queue: ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:36: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:81: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:65: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:71: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m:83: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:72: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:160: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:161: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:163: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:166: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:167: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:183: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:184: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:186: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:187: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:189: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:190: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:204: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:205: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h:12: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h:10: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:804: developmentRegion is not English. [xcodeproj/settings] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.h:21: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.h:15: Missing space after , [whitespace/comma] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:28: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:144: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.h:22: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h:10: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h:27: Missing space after , [whitespace/comma] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:92: Missing space after , [whitespace/comma] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:99: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:109: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:111: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:126: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:139: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:143: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:147: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:151: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:155: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:160: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:164: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:168: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:172: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:172: Missing space after , [whitespace/comma] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:180: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:184: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:188: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:192: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:196: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:200: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:205: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:206: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:207: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:208: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 69 in 64 files If any of these errors are false positives, please file a bug against check-webkit-style.
Thomas Denney
Comment 21 2018-09-21 16:32:36 PDT
Created attachment 350453 [details] Patch
EWS Watchlist
Comment 22 2018-09-21 16:35:12 PDT
Attachment 350453 [details] did not pass style-queue: ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m:28: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h:29: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:790: developmentRegion is not English. [xcodeproj/settings] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h:27: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h:27: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h:28: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 18 in 40 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 23 2018-09-25 12:54:14 PDT
Comment on attachment 350453 [details] Patch Rejecting attachment 350453 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 350453, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=350453&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=187738&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 350453 from bug 187738. Fetching: https://bugs.webkit.org/attachment.cgi?id=350453 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Myles C. Maxfield']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 40 diffs from patch file(s). patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/.gitignore' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.h' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/AppIcon.appiconset/Contents.json' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/Contents.json' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Base.lproj/Main.storyboard' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.h' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.h' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.h' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Default.whlsl' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Julia.whlsl' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Mandelbrot.whlsl' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Info.plist' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.h' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.h' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.h' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.h' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/WHLSL.entitlements' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/_SharedMetal.txt' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/main.m' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/Info.plist' patching file 'Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m' patching file Tools/WebGPUShadingLanguageRI/Test.js Hunk #1 FAILED at 2500. Hunk #2 succeeded at 9420 (offset 1146 lines). 1 out of 2 hunks FAILED -- saving rejects to file Tools/WebGPUShadingLanguageRI/Test.js.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Myles C. Maxfield']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/9346939
Thomas Denney
Comment 24 2018-09-25 13:07:07 PDT
Created attachment 350779 [details] Patch
EWS Watchlist
Comment 25 2018-09-25 13:10:40 PDT
Attachment 350779 [details] did not pass style-queue: ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m:28: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h:29: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:790: developmentRegion is not English. [xcodeproj/settings] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h:27: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h:27: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h:28: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 18 in 40 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 26 2018-09-25 13:50:27 PDT
Comment on attachment 350779 [details] Patch Clearing flags on attachment: 350779 Committed r236472: <https://trac.webkit.org/changeset/236472>
Radar WebKit Bug Importer
Comment 27 2018-09-25 14:23:28 PDT
<rdar://problem/44773982>
Myles C. Maxfield
Comment 28 2018-10-13 15:43:15 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/108
Note You need to log in before you can comment on or make changes to this bug.