Bug 189360

Summary: [WHLSL] Call arguments should be copied as soon as they are evaluated
Product: WebKit Reporter: Thomas Denney <tdenney>
Component: WebGPUAssignee: Thomas Denney <tdenney>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, mmaxfield, tdenney, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 176199, 189202, 189326    
Attachments:
Description Flags
Patch none

Thomas Denney
Reported 2018-09-06 10:52:08 PDT
There is an observable bug in the interpreter whereby the shallow copy of values only occurred after all arguments to a call had been evaluated.
Attachments
Patch (3.18 KB, patch)
2018-09-06 11:00 PDT, Thomas Denney 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Thomas Denney
Comment 1 2018-09-06 11:00:18 PDT
Created attachment 349045 [details] Patch
Myles C. Maxfield
Comment 2 2018-09-06 11:12:27 PDT
Comment on attachment 349045 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349045&action=review > Tools/WebGPUShadingLanguageRI/Evaluator.js:325 > + let result = EBuffer.allowAllocation(() => node.func.implementation(callArguments, node)); I'm confused. Where do the thunks get evaluated? I expected this patch to move code around, but instead it appears to be deleting code?
Myles C. Maxfield
Comment 3 2018-09-06 13:11:01 PDT
Comment on attachment 349045 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349045&action=review >> Tools/WebGPUShadingLanguageRI/Evaluator.js:325 >> + let result = EBuffer.allowAllocation(() => node.func.implementation(callArguments, node)); > > I'm confused. Where do the thunks get evaluated? I expected this patch to move code around, but instead it appears to be deleting code? Got it. Looks good.
WebKit Commit Bot
Comment 4 2018-09-06 13:36:49 PDT
Comment on attachment 349045 [details] Patch Clearing flags on attachment: 349045 Committed r235753: <https://trac.webkit.org/changeset/235753>
WebKit Commit Bot
Comment 5 2018-09-06 13:36:50 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-09-06 13:40:26 PDT
<rdar://problem/44194725>
Myles C. Maxfield
Comment 7 2018-10-13 14:35:26 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/41
Note You need to log in before you can comment on or make changes to this bug.