Bug 191960

Summary: [Win][Clang] SOFT_LINK reports warning: implicit conversion between pointer-to-function and pointer-to-object is a Microsoft extension [-Wmicrosoft-cast]
Product: WebKit Reporter: Fujii Hironori <fujii>
Component: New BugsAssignee: Fujii Hironori <fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, cdumez, cmarcelo, dbates, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=163331
Bug Depends on:    
Bug Blocks: 171618    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews123 for ios-simulator-wk2 none

Fujii Hironori
Reported 2018-11-25 21:41:10 PST
[Win][Clang] SOFT_LINK reports warning: implicit conversion between pointer-to-function and pointer-to-object is a Microsoft extension [-Wmicrosoft-cast] clang-cl reports following warnings: > [5018/6237] Building CXX object Source\WebCore\CMakeFiles\WebCore.dir\rendering\RenderThemeWin.cpp.obj > ..\..\Source\WebCore\rendering\RenderThemeWin.cpp(151,1): warning: implicit conversion between pointer-to-function and pointer-to-object is a Microsoft extension [-Wmicrosoft-cast] > SOFT_LINK(uxtheme, OpenThemeData, HANDLE, WINAPI, (HWND hwnd, LPCWSTR pszClassList), (hwnd, pszClassList)) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > DerivedSources\ForwardingHeaders\wtf/win/SoftLinking.h(51,124): note: expanded from macro 'SOFT_LINK' > softLink##functionName = reinterpret_cast<resultType(callingConvention*)parameterDeclarations>(::EncodePointer(SOFT_LINK_GETPROCADDRESS(library##Library(), #functionName))); \ > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > DerivedSources\ForwardingHeaders\wtf/win/SoftLinking.h(39,34): note: expanded from macro 'SOFT_LINK_GETPROCADDRESS' > #define SOFT_LINK_GETPROCADDRESS GetProcAddress > ^ > ..\..\Source\WebCore\rendering\RenderThemeWin.cpp(151,1): warning: implicit conversion between pointer-to-function and pointer-to-object is a Microsoft extension [-Wmicrosoft-cast] > SOFT_LINK(uxtheme, OpenThemeData, HANDLE, WINAPI, (HWND hwnd, LPCWSTR pszClassList), (hwnd, pszClassList)) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > DerivedSources\ForwardingHeaders\wtf/win/SoftLinking.h(52,104): note: expanded from macro 'SOFT_LINK' > return reinterpret_cast<resultType (callingConvention*) parameterDeclarations>(::DecodePointer(softLink##functionName)) parameterNames; \ > ^~~~~~~~~~~~~~~~~~~~~~ > <scratch space>(239,1): note: expanded from here > softLinkOpenThemeData > ^~~~~~~~~~~~~~~~~~~~~ > ..\..\Source\WebKitLegacy\win\WebView.cpp(221,1): warning: implicit conversion between pointer-to-function and pointer-to-object is a Microsoft extension [-Wmicrosoft-cast] > SOFT_LINK_OPTIONAL(USER32, GetGestureInfo, BOOL, WINAPI, (HGESTUREINFO, PGESTUREINFO)); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > DerivedSources\ForwardingHeaders\wtf/win/SoftLinking.h(63,75): note: expanded from macro 'SOFT_LINK_OPTIONAL' > ptr = reinterpret_cast<functionName##PtrType>(::EncodePointer(SOFT_LINK_GETPROCADDRESS(library##Library(), #functionName))); \ > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > DerivedSources\ForwardingHeaders\wtf/win/SoftLinking.h(39,34): note: expanded from macro 'SOFT_LINK_GETPROCADDRESS' > #define SOFT_LINK_GETPROCADDRESS GetProcAddress > ^
Attachments
Patch (5.88 KB, patch)
2018-11-25 22:44 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (8.88 MB, application/zip)
2018-11-26 17:35 PST, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2018-11-25 22:24:55 PST
It has introduced in Bug 163331 – [Win] Encode function pointers.
Fujii Hironori
Comment 2 2018-11-25 22:44:44 PST
Created attachment 355621 [details] Patch
EWS Watchlist
Comment 3 2018-11-26 17:35:57 PST
Comment on attachment 355621 [details] Patch Attachment 355621 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10159992 New failing tests: media/no-fullscreen-when-hidden.html
EWS Watchlist
Comment 4 2018-11-26 17:35:59 PST
Created attachment 355697 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Fujii Hironori
Comment 5 2018-11-26 18:03:24 PST
Comment on attachment 355621 [details] Patch Clearing flags on attachment: 355621 Committed r238541: <https://trac.webkit.org/changeset/238541>
Fujii Hironori
Comment 6 2018-11-26 18:03:27 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-11-26 18:04:57 PST
<rdar://problem/46263596>
Note You need to log in before you can comment on or make changes to this bug.