Bug 198596

Summary: Web Inspector: Go To Line dialog is white when in Dark Mode
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, jamaln, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch applied
none
Patch none

Devin Rousso
Reported 2019-06-05 19:36:13 PDT
# STEPS TO REPRODUCE: 1. switch to Dark Mode 2. inspect any page 3. go to any resource in the Resources/Debugger/Sources tab 4. press ⌃G => the "Line Number" dialog is white
Attachments
Patch (1.72 KB, patch)
2019-06-07 15:04 PDT, Jamal Nasser 		no flags
DetailsFormatted DiffDiff
Patch applied (165.88 KB, image/png)
2019-06-07 15:25 PDT, Jamal Nasser 		no flags
Details
Patch (1.72 KB, patch)
2019-06-14 23:49 PDT, Jamal Nasser 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jamal Nasser
Comment 1 2019-06-07 15:04:03 PDT
Created attachment 371615 [details] Patch
Jamal Nasser
Comment 2 2019-06-07 15:25:09 PDT
Created attachment 371617 [details] Patch applied
Devin Rousso
Comment 3 2019-06-07 15:32:42 PDT
Comment on attachment 371615 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371615&action=review r=me, nice! > Source/WebInspectorUI/UserInterface/Views/GoToLineDialog.css:98 > + Style: extra newline. > Source/WebInspectorUI/UserInterface/Views/GoToLineDialog.css:115 > + Ditto (>98).
Devin Rousso
Comment 4 2019-06-11 15:10:40 PDT
@Jamal if you upload another patch with the whitespace removed, I'll cq+ this for you :)
Jamal Nasser
Comment 5 2019-06-14 23:49:18 PDT
Created attachment 372177 [details] Patch
WebKit Commit Bot
Comment 6 2019-06-17 12:29:24 PDT
Comment on attachment 372177 [details] Patch Clearing flags on attachment: 372177 Committed r246508: <https://trac.webkit.org/changeset/246508>
WebKit Commit Bot
Comment 7 2019-06-17 12:29:25 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-06-17 12:30:34 PDT
<rdar://problem/51816116>
Note You need to log in before you can comment on or make changes to this bug.