Bug 201700

Summary: Fix PDFKit references in TestWebKitAPI
Product: WebKit Reporter: Keith Rollin <krollin>
Component: Tools / TestsAssignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, thorton, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Use HAVE_PDFKIT. none

Keith Rollin
Reported 2019-09-11 15:33:57 PDT
These references fail in watchOS and tvOS, so remove them on those platforms.
Attachments
Patch (5.98 KB, patch)
2019-09-11 15:35 PDT, Keith Rollin 		no flags
DetailsFormatted DiffDiff
Use HAVE_PDFKIT. (6.39 KB, patch)
2019-09-11 23:17 PDT, Keith Rollin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-09-11 15:34:15 PDT
<rdar://problem/55279539>
Keith Rollin
Comment 2 2019-09-11 15:35:32 PDT
Created attachment 378582 [details] Patch
Alex Christensen
Comment 3 2019-09-11 20:47:43 PDT
Comment on attachment 378582 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378582&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm:28 > +#if PLATFORM(MAC) || PLATFORM(IOS) I think this would be better given a name, like HAVE(PDFKIT)
Alex Christensen
Comment 4 2019-09-11 21:07:21 PDT
Comment on attachment 378582 [details] Patch Otherwise looks good.
Keith Rollin
Comment 5 2019-09-11 23:17:13 PDT
Created attachment 378624 [details] Use HAVE_PDFKIT.
WebKit Commit Bot
Comment 6 2019-09-12 07:13:35 PDT
Comment on attachment 378624 [details] Use HAVE_PDFKIT. Clearing flags on attachment: 378624 Committed r249807: <https://trac.webkit.org/changeset/249807>
WebKit Commit Bot
Comment 7 2019-09-12 07:13:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.