Bug 46988

Summary: REGRESSION (r68887): Web Inspector: inspector/extensions*.html are failing on Windows
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, caseq, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2 Keywords: InRadar, LayoutTestFailure, PlatformOnly, Regression
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://build.webkit.org/results/Windows%20Release%20(Tests)/r68887%20(4667)/results.html
Attachments:
Description Flags
Copy forwarding headers and Inspector JS files as part of WebCoreGenerated.vcproj andersca: review+

Adam Roben (:aroben)
Reported 2010-10-01 09:20:47 PDT
inspector/extensions*.html are failing on Windows. See the URL for an example of the failures.
Attachments
Copy forwarding headers and Inspector JS files as part of WebCoreGenerated.vcproj (15.82 KB, patch)
2010-10-01 11:14 PDT, Adam Roben (:aroben) 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2010-10-01 09:21:24 PDT
<rdar://problem/8502489>
Adam Roben (:aroben)
Comment 2 2010-10-01 10:22:33 PDT
(In reply to bug 45954 comment #8) > the -api.html suggests that frontend is of an older version (i.e. lacks a method introduced in this patch; I don't think there's a space for any flakiness there). This also does not reproduce locally. > Can we clobber the win bots? > Also, I reckon that build-webkit does not copy inspector front-end files under windows, unless --inspector-frontend is specified or there's a larger change outside of inspector/front-end. If clobbering fixes the tests, I think we need to raise a bug for build to perform build-webkit --inspector-frontend at least on bots (it's cheap). OK, it sounds like you're saying that the problem is that there are stale front-end JS files in the bots' build directories. Looking at build-webkit, I can't see how --inspector-frontend actually works. But I don't think a change to build-webkit is the answer. We want this to work for people who build directly from Visual Studio, too. I think the right way to fix this is to move the copying of these files from WebCore.vcproj (which only runs when a .cpp or .h file changes) to WebCoreGenerated.vcproj (which always runs).
Adam Roben (:aroben)
Comment 3 2010-10-01 11:14:52 PDT
Created attachment 69489 [details] Copy forwarding headers and Inspector JS files as part of WebCoreGenerated.vcproj
Adam Roben (:aroben)
Comment 4 2010-10-01 11:32:29 PDT
Committed r68905: <http://trac.webkit.org/changeset/68905>
Note You need to log in before you can comment on or make changes to this bug.