Bug 49484

Created attachment 73791 [details] [PATCH] Proposed Change Removed unimplemented functions and an unused debug variable.

Comment on attachment 73791 [details] [PATCH] Proposed Change View in context: https://bugs.webkit.org/attachment.cgi?id=73791&action=review > WebCore/ChangeLog:23 > + Removed function signatures without any implementation. The functions > + used to exist, and were nicely refactored into PageCache in r60688 and > + the signatures were left behind. > + > + Removed function signature setLoadType. Added in r17238 back when the > + file was named WebFrameLoader, and the implementation was lost during > + the transition from its mm implementation. > + > + Removed function signature updateHistoryAfterClientRedirect. Implementation > + and call points were removed in r18541 but the signature was left behind, > + and jumped files! > + > + Removed unused debug variable m_didDispatchDidCommitLoad. It was added > + and used in Assertions in r28399. It was removed soon after, in r28464 > + because they were, "firing like crazy. Not sure why yet." It was > + never used again. I'd probably put this in the bug, not ChangeLog. But it's nothing compared to the fact that you actually investigated the history in such detail, that's really nice.

The commit-queue encountered the following flaky tests while processing attachment 73791 [details]: http/tests/appcache/insert-html-element-with-manifest-2.html Please file bugs against the tests. These tests were authored by ap@webkit.org. The commit-queue is continuing to process your patch.

Comment on attachment 73791 [details] [PATCH] Proposed Change Clearing flags on attachment: 73791 Committed r71959: <http://trac.webkit.org/changeset/71959>

All reviewed patches have been landed. Closing bug.