Bug 65480

Summary: cr-linux ews bot doesn't compile patch 101925
Product: WebKit Reporter: Ian Henderson <ian>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: abarth, dglazkov, evan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
possible reduction
ian: review-, ian: commit-queue-
possible reduction
ian: commit-queue-
possible reduction
ian: commit-queue-
possible reduction
ian: commit-queue-
possible reduction
ian: commit-queue-
testing hypothesis ian: commit-queue-

Ian Henderson
Reported 2011-08-01 13:02:45 PDT
Created attachment 102545 [details] possible reduction For some reason the cr-linux bot is failing to compile the patches attached to https://bugs.webkit.org/show_bug.cgi?id=65006.
Attachments
possible reduction (1.04 KB, patch)
2011-08-01 13:02 PDT, Ian Henderson 		ian: review-
ian: commit-queue-
DetailsFormatted DiffDiff
possible reduction (1.04 KB, patch)
2011-08-01 13:12 PDT, Ian Henderson 		ian: commit-queue-
DetailsFormatted DiffDiff
possible reduction (3.42 KB, patch)
2011-08-01 15:07 PDT, Ian Henderson 		ian: commit-queue-
DetailsFormatted DiffDiff
possible reduction (4.52 KB, patch)
2011-08-01 15:48 PDT, Ian Henderson 		ian: commit-queue-
DetailsFormatted DiffDiff
possible reduction (811 bytes, patch)
2011-08-01 16:30 PDT, Ian Henderson 		ian: commit-queue-
DetailsFormatted DiffDiff
testing hypothesis (deleted)
2011-08-02 12:05 PDT, Ian Henderson 		ian: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2011-08-01 13:05:21 PDT
Attachment 102545 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/rendering/RenderBoxModelObj..." exit_code: 1 Source/WebCore/rendering/RenderBoxModelObject.cpp:1384: unroundClippedCorners_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ian Henderson
Comment 2 2011-08-01 13:12:21 PDT
Created attachment 102547 [details] possible reduction This is not a real patch, please don't review. I would r- but it causes the EWS bots to ignore the patch.
WebKit Review Bot
Comment 3 2011-08-01 13:14:18 PDT
Attachment 102547 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/rendering/RenderBoxModelObj..." exit_code: 1 Source/WebCore/rendering/RenderBoxModelObject.cpp:1384: unroundClippedCorners_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ian Henderson
Comment 4 2011-08-01 15:07:53 PDT
Created attachment 102566 [details] possible reduction
Ian Henderson
Comment 5 2011-08-01 15:48:19 PDT
Created attachment 102578 [details] possible reduction
WebKit Review Bot
Comment 6 2011-08-01 16:20:53 PDT
Comment on attachment 102578 [details] possible reduction Attachment 102578 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9283710
Adam Barth
Comment 7 2011-08-01 16:24:49 PDT
Source/WebCore/rendering/RenderBoxModelObject.cpp: In member function 'void WebCore::RenderBoxModelObject::paintBoxShadow(WebCore::GraphicsContext*, const WebCore::LayoutRect&, const WebCore::RenderStyle*, WebCore::ShadowStyle, bool, bool)': Source/WebCore/rendering/RenderBoxModelObject.cpp:2249: error: 'cornersIntersect' was not declared in this scope Do you think this is a problem with the bot or with the patch?
Ian Henderson
Comment 8 2011-08-01 16:26:05 PDT
I'm not sure. Evidence points to the bot, since other bots are able to compile it successfully.
Adam Barth
Comment 9 2011-08-01 16:28:24 PDT
> I'm not sure. Evidence points to the bot, since other bots are able to compile it successfully. I bet it will break compile on chromium-linux if you landed it. I'm not sure what's different about the chromium linux configuration that causes the problem.
Ian Henderson
Comment 10 2011-08-01 16:30:06 PDT
Created attachment 102590 [details] possible reduction
Ian Henderson
Comment 11 2011-08-01 16:31:32 PDT
(In reply to comment #9) > > I'm not sure. Evidence points to the bot, since other bots are able to compile it successfully. > > I bet it will break compile on chromium-linux if you landed it. I'm not sure what's different about the chromium linux configuration that causes the problem. Yeah, hopefully it will be more clear with a reduction.
WebKit Review Bot
Comment 12 2011-08-01 16:59:07 PDT
Comment on attachment 102590 [details] possible reduction Attachment 102590 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9285575
Adam Barth
Comment 13 2011-08-01 17:19:15 PDT
How bizzare. gcc bug?
Ian Henderson
Comment 14 2011-08-01 21:04:31 PDT
(In reply to comment #13) > How bizzare. gcc bug? What version of GCC is cr-linux using? Should I try to work around it, or is this a false alarm?
Adam Barth
Comment 15 2011-08-02 00:06:10 PDT
> What version of GCC is cr-linux using? Should I try to work around it, or is this a false alarm? Whatever comes with Ubuntu Lucid. If you'd be willing to work around the issue, that would be helpful. Maybe evmar or tony^work knows more about what's going on.
Tony Chang
Comment 16 2011-08-02 10:09:05 PDT
someStaticFunction is inside a #if HAVE(PATH_BASED_BORDER_RADIUS_DRAWING) block of code. Is that true for Linux/Skia?
Ian Henderson
Comment 17 2011-08-02 12:05:57 PDT
Created attachment 102675 [details] testing hypothesis Nice catch! Let's see what happens if we move the definition outside the #if block.
Ian Henderson
Comment 18 2011-08-02 14:02:33 PDT
Yes, that looks like it was it. I should have thought to check for #if directives earlier. Thanks Tony!
Note You need to log in before you can comment on or make changes to this bug.