Bug 66308

Summary: NRWT should honor --skipped=[default|ignore|only], like ORWT does
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, eric, leandro, ojan, ossy, rakuco, rniwa, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=185054
Bug Depends on:    
Bug Blocks: 88680    
Attachments:
Description Flags
Patch rniwa: review+

Adam Roben (:aroben)
Reported 2011-08-16 08:59:11 PDT
NRWT should honor this flag from ORWT: --skipped=[default|ignore|only] Specifies how to treat the Skipped file default: Tests/directories listed in the Skipped file are not tested ignore: The Skipped file is ignored only: Only those tests/directories listed in the Skipped file will be run
Attachments
Patch (12.39 KB, patch)
2012-06-13 17:45 PDT, Dirk Pranke 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-06-08 18:58:15 PDT
Note that NRWT does have a -f/--force flag, which I think is roughly equivalent to --skipped=ignore . I would assume that this would treat tests marked as SKIP in the TestExpectations files the same way? How should tests that are skipped either because of compile time flags or because they're in other platform directories be treated? The patch would be a lot easier if we ran those as well, but I could see how that might be undesirable.
Dirk Pranke
Comment 2 2012-06-13 17:45:11 PDT
Created attachment 147450 [details] Patch
Dirk Pranke
Comment 3 2012-06-14 12:40:18 PDT
Committed r120348: <http://trac.webkit.org/changeset/120348>
Note You need to log in before you can comment on or make changes to this bug.