Bug 71151

Summary: Rename DataTransferItems to DataTransferItemList
Product: WebKit Reporter: Daniel Cheng <dcheng>
Component: New BugsAssignee: Daniel Cheng <dcheng>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ojan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Daniel Cheng
Reported 2011-10-28 15:30:26 PDT
Rename DataTransferItems to DataTransferItemList
Attachments
Patch (57.31 KB, patch)
2011-10-28 15:31 PDT, Daniel Cheng 		no flags
DetailsFormatted DiffDiff
Patch (61.33 KB, patch)
2011-10-28 15:57 PDT, Daniel Cheng 		no flags
DetailsFormatted DiffDiff
Patch (61.59 KB, patch)
2011-10-28 16:14 PDT, Daniel Cheng 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Daniel Cheng
Comment 1 2011-10-28 15:31:09 PDT
Created attachment 112922 [details] Patch
WebKit Review Bot
Comment 2 2011-10-28 15:33:38 PDT
Attachment 112922 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/dom/Clipboard.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 3 2011-10-28 15:43:21 PDT
Comment on attachment 112922 [details] Patch Attachment 112922 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10244052
Daniel Cheng
Comment 4 2011-10-28 15:57:38 PDT
Created attachment 112931 [details] Patch
WebKit Review Bot
Comment 5 2011-10-28 16:01:48 PDT
Attachment 112931 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/dom/Clipboard.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tony Chang
Comment 6 2011-10-28 16:04:09 PDT
Comment on attachment 112931 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112931&action=review > Source/WebCore/ChangeLog:4 > + Rename DataTransferItems to DataTransferItemList > + https://bugs.webkit.org/show_bug.cgi?id=71151 Do you have a link to where this rename happened?
Daniel Cheng
Comment 7 2011-10-28 16:14:03 PDT
Created attachment 112937 [details] Patch
Daniel Cheng
Comment 8 2011-10-28 16:14:23 PDT
Comment on attachment 112931 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112931&action=review >> Source/WebCore/ChangeLog:4 >> + https://bugs.webkit.org/show_bug.cgi?id=71151 > > Do you have a link to where this rename happened? Added a link to the spec with a little context.
WebKit Review Bot
Comment 9 2011-10-28 16:16:31 PDT
Attachment 112937 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/dom/Clipboard.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tony Chang
Comment 10 2011-10-28 16:18:42 PDT
Comment on attachment 112937 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112937&action=review Please make sure that the ews bots all compile before landing. > Source/WebCore/WebCore.xcodeproj/project.pbxproj:1767 > - 781755861365A1B00093BE2E /* DataTransferItems.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 781755851365A1B00093BE2E /* DataTransferItems.cpp */; }; > + 781755861365A1B00093BE2E /* DataTransferItemList.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 781755851365A1B00093BE2E /* DataTransferItemList.cpp */; }; Did you actually open these in xcode? I think the hash will change because the filename changed . . .
Daniel Bates
Comment 11 2011-10-29 01:18:17 PDT
Comment on attachment 112937 [details] Patch Attachment 112937 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/10241309
Daniel Cheng
Comment 12 2011-10-29 15:53:41 PDT
Comment on attachment 112937 [details] Patch Patched it into a clean tree on Mac and it worked for me.
WebKit Review Bot
Comment 13 2011-10-29 16:27:58 PDT
Comment on attachment 112937 [details] Patch Clearing flags on attachment: 112937 Committed r98821: <http://trac.webkit.org/changeset/98821>
WebKit Review Bot
Comment 14 2011-10-29 16:28:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.