Bug 73219

Summary: Web Inspector: align agent creation (factory vs constructors).
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, burg, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch yurys: review+, webkit-ews: commit-queue-

Pavel Feldman
Reported 2011-11-28 07:44:09 PST
Done for consistency.
Attachments
Patch (29.83 KB, patch)
2011-11-28 07:46 PST, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Patch (16.19 KB, patch)
2011-11-28 08:13 PST, Pavel Feldman 		yurys: review+
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-11-28 07:46:24 PST
Created attachment 116758 [details] Patch
Pavel Feldman
Comment 2 2011-11-28 08:13:14 PST
Created attachment 116762 [details] Patch
Yury Semikhatsky
Comment 3 2011-11-28 08:56:03 PST
Comment on attachment 116762 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116762&action=review > Source/WebCore/inspector/PageConsoleAgent.h:35 > +#include <wtf/PassOwnPtr.h> Here and in other places, can you move implementation of the factory methods to cpp, that way you wouldn't need this include?
Early Warning System Bot
Comment 4 2011-11-28 08:59:47 PST
Comment on attachment 116762 [details] Patch Attachment 116762 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10662037
Gyuyoung Kim
Comment 5 2011-11-28 09:04:42 PST
Comment on attachment 116762 [details] Patch Attachment 116762 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/10669907
WebKit Review Bot
Comment 6 2011-11-28 09:13:44 PST
Comment on attachment 116762 [details] Patch Attachment 116762 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10659024
Brian Burg
Comment 7 2014-08-03 18:34:50 PDT
This was cleaned up by JoePeck when enabling JSContext inspection.
Note You need to log in before you can comment on or make changes to this bug.