Bug 74266

Summary: [Refactoring] In prepare-ChangeLog, move into a method the top-level code to show ChangeLogs diff and open ChangeLogs in an editor
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: Tools / TestsAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, ddkilzer, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 73531    
Attachments:
Description Flags
Patch
rniwa: review+
patch for commit none

Kentaro Hara
Reported 2011-12-11 23:25:33 PST
We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest manner. This bug is one of the incremental refactorings to remove all top-level code and global variables from prepare-ChangeLog. FYI: After this patch is landed, I'll work on removing all global variables.
Attachments
Patch (5.61 KB, patch)
2011-12-11 23:33 PST, Kentaro Hara 		rniwa: review+
DetailsFormatted DiffDiff
patch for commit (5.61 KB, patch)
2011-12-11 23:43 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2011-12-11 23:33:07 PST
Created attachment 118741 [details] Patch
Ryosuke Niwa
Comment 2 2011-12-11 23:41:16 PST
Comment on attachment 118741 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118741&action=review > Tools/ChangeLog:3 > + [Refactoring] In prepare-ChangeLog, move into a method the top-level code to show ChangeLogs diff and open ChangeLogs in an editor Split this line into two lines?
Kentaro Hara
Comment 3 2011-12-11 23:43:17 PST
Created attachment 118742 [details] patch for commit
Kentaro Hara
Comment 4 2011-12-11 23:43:42 PST
(In reply to comment #2) > (From update of attachment 118741 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=118741&action=review > > > Tools/ChangeLog:3 > > + [Refactoring] In prepare-ChangeLog, move into a method the top-level code to show ChangeLogs diff and open ChangeLogs in an editor > > Split this line into two lines? Done. Thanks.
WebKit Review Bot
Comment 5 2011-12-12 00:59:15 PST
Comment on attachment 118742 [details] patch for commit Clearing flags on attachment: 118742 Committed r102562: <http://trac.webkit.org/changeset/102562>
David Kilzer (:ddkilzer)
Comment 6 2011-12-12 08:55:49 PST
Manually marking bug as RESOLVED/FIXED.
Note You need to log in before you can comment on or make changes to this bug.