Bug 92238

Summary: Add *explicit* keyword to constructors in WebCore/platform
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: New BugsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: haraken, ossy, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 92273, 92315    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Gyuyoung Kim
Reported 2012-07-25 03:59:41 PDT
As my previous patches, this bug is to add *explicit* keyword to constructors which have a parameter in WebCore/platform. But, some constructors make build breaks when *explicit* is added to them. So,they are excepted from this patch.
Attachments
Patch (18.17 KB, patch)
2012-07-25 04:03 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (17.59 KB, patch)
2012-07-25 05:59 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (16.79 KB, patch)
2012-07-25 17:44 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2012-07-25 04:03:10 PDT
Created attachment 154320 [details] Patch
Gyuyoung Kim
Comment 2 2012-07-25 04:03:55 PDT
Because this patch touches port specific files, this patch should pass all ews.
Kentaro Hara
Comment 3 2012-07-25 04:20:13 PDT
Comment on attachment 154320 [details] Patch OK
Early Warning System Bot
Comment 4 2012-07-25 04:33:06 PDT
Comment on attachment 154320 [details] Patch Attachment 154320 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13361011
Early Warning System Bot
Comment 5 2012-07-25 05:13:43 PDT
Comment on attachment 154320 [details] Patch Attachment 154320 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13340231
Gyuyoung Kim
Comment 6 2012-07-25 05:59:02 PDT
Created attachment 154331 [details] Patch
Gyuyoung Kim
Comment 7 2012-07-25 08:22:32 PDT
Comment on attachment 154331 [details] Patch There is no build break on mac port as well.
WebKit Review Bot
Comment 8 2012-07-25 09:14:16 PDT
Comment on attachment 154331 [details] Patch Clearing flags on attachment: 154331 Committed r123625: <http://trac.webkit.org/changeset/123625>
WebKit Review Bot
Comment 9 2012-07-25 09:14:20 PDT
All reviewed patches have been landed. Closing bug.
Allan Sandfeld Jensen
Comment 10 2012-07-25 09:16:31 PDT
Comment on attachment 154331 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154331&action=review > Source/WebCore/platform/Cursor.h:161 > - Cursor(const Cursor&); > + explicit Cursor(const Cursor&); The rest looks good, but this change looks kinda weird. Why should the copy constructor be explicit?
Csaba Osztrogonác
Comment 11 2012-07-25 11:25:58 PDT
(In reply to comment #8) > (From update of attachment 154331 [details]) > Clearing flags on attachment: 154331 > > Committed r123625: <http://trac.webkit.org/changeset/123625> It broke the build on Qt Mac - https://bugs.webkit.org/show_bug.cgi?id=92273
Ryosuke Niwa
Comment 12 2012-07-25 16:21:24 PDT
Also broke Windows builds. Rolling it out.
WebKit Review Bot
Comment 13 2012-07-25 16:22:21 PDT
Re-opened since this is blocked by 92315
Gyuyoung Kim
Comment 14 2012-07-25 17:30:38 PDT
I'm really sorry for making build breaks for other ports. Though I tried to check all EWS, build breaks occur on ports which don't support EWS. It looks QT Mac, window build should be tested as well. I'm going to check them again. Could you let me know which ports should I test further?
Ryosuke Niwa
Comment 15 2012-07-25 17:33:37 PDT
(In reply to comment #14) > I'm really sorry for making build breaks for other ports. Though I tried to check all EWS, build breaks occur on ports which don't support EWS. It looks QT Mac, window build should be tested as well. I'm going to check them again. Could you let me know which ports should I test further? It also broke my Mac gcc (Xcode 3.x) builds.
Gyuyoung Kim
Comment 16 2012-07-25 17:44:52 PDT
Created attachment 154503 [details] Patch
Gyuyoung Kim
Comment 17 2012-07-25 17:48:16 PDT
(In reply to comment #15) > (In reply to comment #14) > > I'm really sorry for making build breaks for other ports. Though I tried to check all EWS, build breaks occur on ports which don't support EWS. It looks QT Mac, window build should be tested as well. I'm going to check them again. Could you let me know which ports should I test further? > > It also broke my Mac gcc (Xcode 3.x) builds. I remove some dangerous codes in new patch. But, I will check it as well. After verifying this patch on all ports, I will land this patch. Sorry again.
Gyuyoung Kim
Comment 18 2012-07-26 00:39:50 PDT
(In reply to comment #15) > It also broke my Mac gcc (Xcode 3.x) builds. I just verified that there is no build break on Xcode 3.2.6 with latest patch.
Kentaro Hara
Comment 19 2012-07-26 00:43:10 PDT
(In reply to comment #18) > > It also broke my Mac gcc (Xcode 3.x) builds. > > I just verified that there is no build break on Xcode 3.2.6 with latest patch. As far as I scan the new patch, it looks OK. Shall we try to land it and keep watching the tree so that we can roll it out immediately in case it breaks something?
WebKit Review Bot
Comment 20 2012-07-26 01:55:35 PDT
Comment on attachment 154503 [details] Patch Clearing flags on attachment: 154503 Committed r123716: <http://trac.webkit.org/changeset/123716>
WebKit Review Bot
Comment 21 2012-07-26 01:55:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.