WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 40443
32002
Bug in custom JS bindings for texImage2D and texSubImage2D
https://bugs.webkit.org/show_bug.cgi?id=32002
Summary
Bug in custom JS bindings for texImage2D and texSubImage2D
Kenneth Russell
Reported
2009-11-30 16:16:18 PST
I happened to notice via code inspection that the flipY and premultiplyAlpha boolean values are being set from the same incoming argument in the custom JS bindings for texImage2D and texSubImage2D. The errors are around lines 377-378 and 413-414 in WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp. I'm not sure whether GraphicsContext3DMac.cpp is supposed to handle the flipY argument properly yet, but if it is then this is probably why it isn't taking effect.
Attachments
Add attachment
proposed patch, testcase, etc.
Oliver Hunt
Comment 1
2009-11-30 16:18:50 PST
(In reply to
comment #0
)
> I happened to notice via code inspection that the flipY and premultiplyAlpha > boolean values are being set from the same incoming argument in the custom JS > bindings for texImage2D and texSubImage2D. The errors are around lines 377-378 > and 413-414 in WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp. I'm not > sure whether GraphicsContext3DMac.cpp is supposed to handle the flipY argument > properly yet, but if it is then this is probably why it isn't taking effect.
irk, what i would give for autogen of variadic functions... :-/
Kenneth Russell
Comment 2
2010-08-05 12:30:26 PDT
This was implicitly fixed in the deletion of the custom JSC bindings for texImage2D in
bug 40443
. *** This bug has been marked as a duplicate of
bug 40443
***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug