RESOLVED FIXED224513
Stop requiring a RemoteRenderingBackend for visibility propagation views 
https://bugs.webkit.org/show_bug.cgi?id=224513
Summary Stop requiring a RemoteRenderingBackend for visibility propagation views
Chris Dumez
Reported 2021-04-13 15:14:34 PDT
Stop requiring a RemoteRenderingBackend for visibility propagation views. This is inconvenient because doing media playback in the GPUProcess does not require a RemoteRenderingBackend. This also makes things difficult to exit the GPUProcess on memory pressure when unused.
Attachments
Patch (19.26 KB, patch)
2021-04-13 15:29 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (19.54 KB, patch)
2021-04-13 16:03 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-04-13 15:29:48 PDT
Created attachment 425922 [details] Patch
Geoffrey Garen
Comment 2 2021-04-13 15:52:08 PDT
Comment on attachment 425922 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425922&action=review r=me > Source/WebKit/WebProcess/WebPage/WebPage.cpp:857 > +#if ENABLE(GPU_PROCESS) > + if (auto* gpuProcessConnection = WebProcess::singleton().existingGPUProcessConnection()) > + gpuProcessConnection->createVisibilityPropagationContextForPage(*this); > +#endif // ENABLE(GPU_PROCESS) > +#endif // HAVE(VISIBILITY_PROPAGATION_VIEW) Feels slightly better to call gpuProcessConnectionDidBecomeAvailable() here instead -- in case someone adds "things to do when I get a GPU Process" logic in the future.
Chris Dumez
Comment 3 2021-04-13 16:03:50 PDT
Created attachment 425928 [details] Patch
EWS
Comment 4 2021-04-13 17:37:13 PDT
Committed r275921 (236484@main): <https://commits.webkit.org/236484@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425928 [details].
Radar WebKit Bug Importer
Comment 5 2021-04-13 17:38:15 PDT
<rdar://problem/76619462>
Chris Dumez
Comment 6 2021-04-13 20:48:36 PDT
Follow-up in <https://commits.webkit.org/r275928> to address crashes on the iOS bot.
Note You need to log in before you can comment on or make changes to this bug.